Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event detail pages #31

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

event detail pages #31

wants to merge 4 commits into from

Conversation

rizkyalviandra
Copy link
Contributor

No description provided.

@mnindrazaka
Copy link
Contributor

Please give screenshot of page that you work on

@rizkyalviandra
Copy link
Contributor Author

Please give screenshot of page that you work on

whatsapp image 2019-02-13 at 1 48 53 pm

mnindrazaka
mnindrazaka suggested changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@mnindrazaka mnindrazaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the style outside component using Stylesheet.create() to make the code cleaner, you can use eventName, eventDate, eventLocation, eventOrganizer, etc to name your style

src/pages/main/EventDetail/index.tsx Outdated
{/* <View style={styles.bannerContainer}> */}
<ImageBackground source={require('../../../../assets/FB.jpg')} resizeMode={"cover"} style={styles.bannerContainer} />
<View style={styles.text}>
<Text style={{ fontSize: 30 }}>Event Name</Text>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the style outside component using Stylesheet.create() to make the code cleaner, you can use eventName, eventDate, eventLocation, eventOrganizer, etc to name your style

Copy link
Contributor Author

@rizkyalviandra rizkyalviandra Feb 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the style outside component using Stylesheet.create() to make the code cleaner, you can use eventName, eventDate, eventLocation, eventOrganizer, etc to name your style

i've already replaced the style to style outside component. Please check again

mnindrazaka
mnindrazaka suggested changes Feb 28, 2019
View reviewed changes
src/pages/main/EventDetail/index.tsx Outdated
@@ -48,25 +44,17 @@ export default class EventDetail extends Component<IProps> {
quis. Maecenas fringilla orci at lacinia luctus.
</Text>
</View>
<View style={{ margin: 30 }} />
<View style={styles.eventSpacing} />
Copy link
Contributor

@mnindrazaka mnindrazaka Feb 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use whitespace component from ant design to make this
https://rn.mobile.ant.design/components/white-space/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnindrazaka mnindrazaka Awaiting requested review from mnindrazaka

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rizkyalviandra @mnindrazaka